Embedded media breaks paragraphs also

[phillipadsmith]

Example of embedded media causes a weird paragraph break/wrap:
http://preview.thetyee.ca/Culture/2016/01/13/Podcast-Overload/

[MrBryan]

In this case it actually is fitting between two paragraphs i.e. it's not breaking up text that is all in one but it is causing the left edge of the text to shift for the rest of the story? (or shift the other way above)

[phillipadsmith]

In this case it actually is fitting between two paragraphs

Ah, yes, my mistake.

but it is causing the left edge of the text to shift for the rest of the story? (or shift the other way above)

It's doing something weird, yes.

[alexgreen]

There's 2 problems here:

1. The player is not appearing within a <figure> (as all media and imgs should), it's just sitting in an iframe directly within the main column. Proper figure tag markup is necessary to ensure correct styling and behaviour of media objects.
2. There's a superfluous </div> after the iframe and this prematurely closes the main column's <div class="container-fluid clearfix ">. According to my tests this is what causes the problem with the column edge alignment.

<p>It's mesmerizing. There isn't a bad episode in more than a year's worth of podcasts. But since you need something to brighten the dark cold of January, why not start with sex? The Feb. 25, 2015 episode, "Cheating Happens," is about something roughly a quarter of married people do.</p>

                              <iframe frameborder="0" scrolling="no" height="130" width="100%" src="https://www.wnyc.org/widgets/ondemand_player/deathsexmoney/#file=/audio/json/433293/&share=1"></iframe>
</div><!--/responsive-embed--> 
<p>Happy fantasizing.</p>

@MrBryan is there some way that legacy articles can be processed so that all iframes pasted within the body text are wrapped in appropriately marked up figures? That way they'll get correct styling. If not then I can try to apply a universal style to iframes appearing within the column.

@MrBryan do you know where that extra </div> is coming from? Can it be omitted?

[alexgreen]

Here's an example of how it looks in Jekyll:
{% include 01-molecules/blocks/figure.html figure-contents="00-atoms/media/audio--wnyc-player" figure-caption="This is a caption describing an audio object inside a figure." media-credit="Source attribution goes here" content-source="" %}

And here's the html output:

<!-- Begin 01-molecules/blocks/figure -->
<figure class="figure " data-dev-object-descrip="01-molecules/blocks/figure" data-dev-status="IN-PROGRESS">
    <!-- 00-atoms/media/audio -- audio embed.  -->
    <div class="[ responsive-embed responsive-embed--audio ]">
       <iframe frameborder="0" scrolling="no" height="130" width="100%" src="https://www.wnyc.org/widgets/ondemand_player/deathsexmoney/#file=/audio/json/433293/&amp;share=1"></iframe>
    </div>
    <!-- END 00-atoms/media/audio -->
    <figcaption class="caption">This is a caption describing an audio object inside a figure. <span class="caption__media--credit"> Source attribution goes here</span></figcaption>
</figure>
<!-- END 01-molecules/blocks/figure -->

[phillipadsmith]

Is this merged in, @MrBryan ?