Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency deletion of non submitted OONI reports #53

Open
anadahz opened this issue Jun 29, 2016 · 7 comments
Open

Emergency deletion of non submitted OONI reports #53

anadahz opened this issue Jun 29, 2016 · 7 comments

Comments

@anadahz
Copy link
Member

anadahz commented Jun 29, 2016

The image should have enough free disk space for new ooniprobe measurements and system files in order for the OS to operate properly.

Currently we don't enforce any emergency deletion process, if for any reason the disk space fills up (cannot communicate with backend) the OS will not be able to recover and Raspberry Pi will turn in a boot cycle or became a useless brick that doesn't perform/submits any ooniprobe measurements.

On the other hand we may lose important measurement reports that occurred in a specific event i.e a country's network completely blocking outgoing/incoming connections for a long time. If we don't automatically delete these reports a person can manually recover the reports (from the SD card) and extract useful information about this incident from the OONI measurements.

cc: @hellais @willscott @bassosimone @agrabeli

@bassosimone
Copy link
Contributor

I'd check whether we're short in disk space and avoid running measurements in that case, so to avoid filling up all the disk. Does it make sense?

@anadahz
Copy link
Member Author

anadahz commented Jul 4, 2016

@bassosimone preferably we should not stop performing measurements in lepidopter, since lepidopter is suppose to do OONI measurements...

@bassosimone
Copy link
Contributor

@anadahz I agree, there is clearly a trade-off between filling the whole disk and running new measurements. What is more important in case the collector is unreachable and the disk is quickly filling up? Older or newer reports? Would it make sense, instead of pausing, to delete older reports?

@anadahz
Copy link
Member Author

anadahz commented Jul 14, 2016

@bassosimone another idea will be to compress these reports and try to upload them (with on the fly extraction) at regular intervals, when the disk space fills up to a critical low (say 500M) we could delete there reports.

@bassosimone
Copy link
Contributor

@anadahz yes, this could be a good way to solve the problem!

@anadahz anadahz added this to the lepidopter 0.3.0-beta release milestone Aug 28, 2016
hellais added a commit to ooni/probe that referenced this issue Aug 30, 2016
This is related to the feature described in here: TheTorProject/lepidopter#53
@anadahz
Copy link
Member Author

anadahz commented Sep 1, 2016

Since the OONI reports deletion is going to be handled by the disk quota implementation in ooniprobe.
I have made #75 that deletes log files and other lower priority files triggered by critical (98%) or warning (95%) disk usage percentage.

@anadahz
Copy link
Member Author

anadahz commented Sep 14, 2016

I'm going to move this to future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants