Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using it in container mode, it lost the awareness of the actual os and shell #111

Open
binaryoak opened this issue Mar 28, 2023 · 4 comments
Labels
docker Docker related enhancement New feature or request

Comments

@binaryoak
Copy link

for example, I am using macos, yet when I asked the system update commands, it gave me the ones for debian/ubuntu, because this is the env of the docker image.

maybe supporting providing such info in the config files or some env vars?

@AnkitGupta17134
Copy link

How are you sure its referring to base image(linux) of docker to answer regarding update commands?

@binaryoak
Copy link
Author

because my os is macos, yet the system update command it gave was apt-get which is for the base image used by python-3-slim -- FROM debian:bullseye-slim

@TheR1D TheR1D added bug Something isn't working enhancement New feature or request docker Docker related and removed bug Something isn't working labels Mar 29, 2023
@saifmode
Copy link

saifmode commented Apr 2, 2023

I addressed this in my fork https://github.com/saifmode/shell_gpt

@TheR1D feel free to cherry pick this commit cec01d0
I also added support for other models in my fork.

@binaryoak Please note, when running a docker build you should also specify your shell. For example, if your Mac is running ZSH, but you're running ShellGPT via docker, it will think you're running PowerShell, and sometimes the chatbot will claim it doesn't know about ZSH. Check the README.md in my fork for more info on how to put the correct OS and shell into your docker container's env vars.

@Robinsane
Copy link

I think my PR #540 offers a decent solution to this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants