Use of deprecated ConstructorInitializerAllOnOneLineOrOnePerLine .clang-format option

[huand]

ModernCppStarter/.clang-format

Line 9 in f0b5bdb

ConstructorInitializerAllOnOneLineOrOnePerLine: 'true'

Documentation says it's deprecated

I think what you want is

BinPackParameters: false
BinPackArguments: false

[ClausKlein]

IMHO: we should use this: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#packconstructorinitializers

[huand]

Possibly, I'm not well versed in the "most commonly admitted consensual .clang-format practices" so I'll let the decision to others. I was just looking through the definitions and I saw something deprecated which is not the best default i believe for a modern starter.

As a digression I went through the options because originally i wanted to have the & "on the left" for function definitions like auto fn(const Type& x) instead of auto fn(const Type &x) and i believe this .clang-format does not enforce this as it is

DerivePointerAlignment: false
PointerAlignment: Left

I also don't know if this "left alignment" is a standard practice.

[TheLartians]

Thanks for the heads up! I wasn't aware that the option was deprecated. Happy to accept a PR that updates the config without impacting the other style settings much.