Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Stop the DSA PR #61

Open
mkubdev opened this issue Oct 22, 2022 · 10 comments
Open

[Core] Stop the DSA PR #61

mkubdev opened this issue Oct 22, 2022 · 10 comments
Labels
in-discussion question Further information is requested

Comments

@mkubdev
Copy link
Member

mkubdev commented Oct 22, 2022

Hello 馃憢馃徎

This repos is taking a wrong direction. Solidity language isn't suited for heavy mathematics computing.

I think we need to remove the list that looks like DSA, and restructure the repos to list Solidity use cases instead.

@mkubdev mkubdev added question Further information is requested in-discussion labels Oct 22, 2022
@0xSumitBanik
Copy link
Contributor

@mkubdev , Let me know what do you think about #58 . I just added the missing tests in this.
And, Let me also know if #60 is invalid considering the points you mentioned in this issue?

Thanks :)

@Panquesito7 Panquesito7 pinned this issue Oct 23, 2022
@sreekar9601
Copy link
Collaborator

We should make sub-sections in a way such that it's more useful for implementation,
example: Algos commonly used in DeFi, NFTs, etc.

@Perelyn-sama
Copy link
Contributor

@sreekar9601 great idea

@mkubdev I think continuing won't be a bad idea.
Yeah, solidity is not the best language for DSA but when we attempt to write common algos in it, we learn more about the language.

Also, I think we have to give a thought to writing algos in Yul and Huff since they're more suited for mathematical operations.

@iSumitBanik and @sreekar9601 thanks for your contributions, its nice to not be alone anymore.

@0xSumitBanik
Copy link
Contributor

Also, I think we have to give a thought to writing algos in Yul and Huff since they're more suited for mathematical operations.

Agreed with this point. Writing in Yul/Huff would let us contribute some heavily gas optimized contracts ;)

@priyda
Copy link
Contributor

priyda commented Nov 27, 2022

Hello 馃憢馃徎

This repos is taking a wrong direction. Solidity language isn't suited for heavy mathematics computing.

I think we need to remove the list that looks like DSA, and restructure the repos to list Solidity use cases instead.

@mkubdev - I would be interested in contributing for non DSA, I am learning solidity by example. Should I add some simple contracts which I am trying for learning the language features?

@mkubdev
Copy link
Member Author

mkubdev commented Nov 28, 2022

@priyda - sure! :)

@mkubdev
Copy link
Member Author

mkubdev commented Dec 2, 2022

@mkubdev - I would be interested in contributing for non DSA, I am learning solidity by example. Should I add some simple contracts which I am trying for learning the language features?

How do you think packaging this examples?

@priyda
Copy link
Contributor

priyda commented Dec 15, 2022

@mkubdev - I would be interested in contributing for non DSA, I am learning solidity by example. Should I add some simple contracts which I am trying for learning the language features?

How do you think packaging this examples?

@mkubdev - I have raised a pull request #77, can you please review that once? If looks good. I have more to add for your review :)

@mkubdev
Copy link
Member Author

mkubdev commented Dec 15, 2022

@mkubdev - I would be interested in contributing for non DSA, I am learning solidity by example. Should I add some simple contracts which I am trying for learning the language features?

How do you think packaging this examples?

@mkubdev - I have raised a pull request #77, can you please review that once? If looks good. I have more to add for your review :)

Sure, i'll review it as soon as i'm available. :D

@0xSumitBanik
Copy link
Contributor

@mkubdev - I would be interested in contributing for non DSA, I am learning solidity by example. Should I add some simple contracts which I am trying for learning the language features?

How do you think packaging this examples?

@mkubdev - I have raised a pull request #77, can you please review that once? If looks good. I have more to add for your review :)

I added a few comments from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-discussion question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants