Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to numpy 2.0 #11320

Open
cclauss opened this issue Mar 12, 2024 · 3 comments
Open

Migrate to numpy 2.0 #11320

cclauss opened this issue Mar 12, 2024 · 3 comments
Labels
enhancement This PR modified some existing files

Comments

@cclauss
Copy link
Member

cclauss commented Mar 12, 2024

Feature description

The beta release of numpy is now available so we should run the appropriate ruff command and ensure our algorithms are compatible... https://numpy.org/devdocs/numpy_2_0_migration_guide.html

@MaximSmolskiy

@cclauss cclauss added the enhancement This PR modified some existing files label Mar 12, 2024
@MaximSmolskiy
Copy link
Contributor

@cclauss I think this rule is already checked and satisfied.

Command

ruff check --select NPY201

does not show any violations.

And in https://docs.astral.sh/ruff/rules/#numpy-specific-rules-npy I do not see any specific signs near NPY201 rule to believe that it is not included by default in https://github.com/TheAlgorithms/Python/blob/master/pyproject.toml#L48

@cclauss
Copy link
Member Author

cclauss commented Apr 1, 2024

Are there other tasks required to complete the upgrade?

@MaximSmolskiy MaximSmolskiy mentioned this issue Apr 1, 2024
15 tasks
@MaximSmolskiy
Copy link
Contributor

As I understand, experiment in #11340 shows that some packages (statsmodels, scikit-learn and maybe some more) are not ready for numpy 2.0 - there are problems on Install dependencies stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

2 participants