Added Goldbach's conjecture #11131
Added Goldbach's conjecture #11131
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| This program will search every even number less than the inputted number and then show which numbers passed the test and which didn't. | ||
| ''' | ||
|
|
||
| def isprime(num): |
There was a problem hiding this comment.
Please provide return type hint for the function: isprime. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function isprime
Please provide type hint for the parameter: num
| return False | ||
| else: | ||
| return True | ||
| def istrue(x): |
There was a problem hiding this comment.
Please provide return type hint for the function: istrue. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function istrue
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def isprime(num): |
There was a problem hiding this comment.
Please provide return type hint for the function: isprime. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function isprime
Please provide type hint for the parameter: num
| return True | ||
|
|
||
|
|
||
| def istrue(x): |
There was a problem hiding this comment.
Please provide return type hint for the function: istrue. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function istrue
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def isprime(num): |
There was a problem hiding this comment.
Please provide return type hint for the function: isprime. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function isprime
Please provide type hint for the parameter: num
| return True | ||
|
|
||
|
|
||
| def istrue(x): |
There was a problem hiding this comment.
Please provide return type hint for the function: istrue. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function istrue
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| and then show which numbers passed the test and which didn't. | ||
| ''' | ||
|
|
||
| def isprime(num): |
There was a problem hiding this comment.
Please provide return type hint for the function: isprime. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function isprime
Please provide type hint for the parameter: num
| return True | ||
|
|
||
|
|
||
| def istrue(x): |
There was a problem hiding this comment.
Please provide return type hint for the function: istrue. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function istrue
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def isprime(num): |
There was a problem hiding this comment.
Please provide return type hint for the function: isprime. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function isprime
Please provide type hint for the parameter: num
| return True | ||
|
|
||
|
|
||
| def istrue(x): |
There was a problem hiding this comment.
Please provide return type hint for the function: istrue. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/Goldbach's conjecture.py, please provide doctest for the function istrue
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
for more information, see https://pre-commit.ci
cclauss
added
ON HOLD: Final hours of Hacktoberfest
Describe your change:
Fixes #11128
Checklist: