Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Broken GitHub links that point to implementations #154

Open
Panquesito7 opened this issue Nov 24, 2021 · 9 comments
Open

[BUG]: Broken GitHub links that point to implementations #154

Panquesito7 opened this issue Nov 24, 2021 · 9 comments
Assignees
Labels
bug dont-close This issue/pull request shouldn't be closed

Comments

@Panquesito7
Copy link
Member

This issue was found thanks to @siriak that reported it in TheAlgorithms/website#142.
Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

@itsmohitmkk
Copy link

Hey,
I have created a pull-request fixing this issue.

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 3, 2022
@Panquesito7 Panquesito7 added dont-close This issue/pull request shouldn't be closed and removed stale labels Jan 3, 2022
@sambhavsaxena
Copy link

is this issue still valid?

@Panquesito7
Copy link
Member Author

is this issue still valid?

Yep, it's still valid. 🙂

@ahmedsaheed
Copy link

Has the links been replaced?

@alaanescobedo
Copy link
Contributor

alaanescobedo commented Apr 24, 2022

Hi @Panquesito7, I think I fixed all the links that were broken except one which is "https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/selecting/quickSelect.cpp", I didn't find the location of the file. But the real problem... there are more than 100 links!😲 , I don't know if you still want the PR to be done, and if so, do you want all the changes to be uploaded in a single PR?

@Panquesito7
Copy link
Member Author

Hey there! A single PR should be fine, as long as it's for the same repository (in this case, C++).
Sorry for the very late reply. Thanks for your interest in contributing. 🙂

@lukasb1b
Copy link

lukasb1b commented Sep 4, 2023

This issue was found thanks to @siriak that reported it in TheAlgorithms/website#142. Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

Do you mean we need ti change the links to the algorithem website?

@appgurueu
Copy link
Collaborator

This issue was found thanks to @siriak that reported it in TheAlgorithms/website#142. Anyone who wants to work on it, feel free to let us know below, and we'll assign you! 🙂

Do you mean we need ti change the links to the algorithem website?

To be honest, we should consider getting rid of the links entirely. On the website, they are redundant. If people choose to browse on GitHub, they can find the implementations by searching on the website; a single website link in the readme suffices for that. If we do want to add these links for convenience, a single link to the appropriate algorithm page on the website should be used (rather than links for all languages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dont-close This issue/pull request shouldn't be closed
Projects
None yet
Development

No branches or pull requests

7 participants