Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bspline Representations Not Rendering Properly Across Several Test Files #520

Open
nickcastel50 opened this issue Oct 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nickcastel50
Copy link

What happened?

It appears BSpline representations aren't working across a handful of test files I've tried. I've sent the test files to @beachtom but they are below for reference:

Link 1: https://github.com/buildingSMART/IFC/blob/master/Examples/Advanced%20geometric%20shape/Examples/Basin%20advanced%20brep/File.ifc

Link 2: https://github.com/buildingSMART/IFC/blob/master/Examples/Advanced%20geometric%20shape/Examples/Cube%20advanced%20Brep/File.ifc

I'm currently doing a deep dive in trying to identify the issue, so far I've noticed this:

It appears BSplineSurface.WeightPoints are set here: https://github.com/IFCjs/web-ifc/blob/689fde101c807a0b8474f014561f153a1a637722/src/wasm/geometry/IfcGeometryProcessor.cpp#L1383

But in TriangulateBspline, it is trying to iterate over the "Weights" field, which is never set as far as I can tell: https://github.com/IFCjs/web-ifc/blob/689fde101c807a0b8474f014561f153a1a637722/src/wasm/geometry/operations/mesh_utils.h#L623

Will update as I glean some more information.

Version

Latest

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

Anything else?

No response

@nickcastel50 nickcastel50 added the bug Something isn't working label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant