-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out any NUL keystrokes that aren't Ctrl+2/Ctrl+space #3280
Conversation
Note that this also solves the problem of the Command Palette popping up when you paste something into an input field in Windows. |
Taking this back to draft for a moment. While it seems to work fine in Windows under Parallels on my Mac, it's not working fine on the native Windows installation. This might be down to Windows Terminal version or something, amongst other things, so I want to double-check all of that. |
Key differences between working and non-working environments: Working
Non-working
ConclusionThe first thing to try is to update the version of Windows Terminal so it's the same in both places. |
Updated to the same version of Windows Terminal, on the native Windows 10 machine, and it made not a jot of difference. I'll throw in some low-level debugging again to see what's coming through. The machine also has the option to be upgraded to Windows 11, but I'm not going to jump into doing that just yet -- having a Windows 10 machine to hand to test with does make a lot of sense; especially if that is the difference. |
microsoft/terminal#2865 may be important here. |
Even odder. This PR, under Windows 11, under Parallels, on macOS, still supports Ctrl+Space. OTOH @rodrigogiraoserrao reports that Windows 11 native, with this PR, shows nothing for the same key combination; while at the same time without the PR shows |
I've also been doing some testing on my Windows 10 if it helps. Running With this PR, |
@TomJGooding Thanks, looks like you're seeing what I'm seeing. |
Which, just to make sure we're on the same page, is the same as I was seeing. |
So, having tested native on Windows 11 here too now, and seeing the same effect, this little hack doesn't quite solve the problem at all. Or, more to the point: it does seem to solve the problem but at the expense of Ctrl+Space; this might be an acceptable loss if #872 is a bigger problem. I'm going to leave this as draft while we think on this and explore other options1. Meanwhile we'll move the Command Palette onto a different keyboard combination that we can be more confident about. Footnotes
|
I guess even if you had Emacs you couldn't set a mark either.... 😉 |
M-x |
You may have found this already, but I stumbled on the debug tap mode for Windows Terminal which might be useful? |
Thanks, no, didn't know of that (really not a Windows user myself). Note that it's the data coming out of |
Closing this PR as it seems the downsides outweigh how trivial it is, and hopefully there's a more fundamental solution to be had with something like #3411. |
See #872.