Fix animation of offset with tuple and string #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalmo
commented
Aug 3, 2023
| # If destination is a pair of numbers, we can convert it to a | ||
| # scalar offset | ||
| elif isinstance(value, tuple) and ( | ||
| list(map(type, value)) == [int, int] |
There was a problem hiding this comment.
This basically checks that value is of type tuple[int, int] or tuple[float, float].
This is the best way I found to implement it.
If anyone has any suggestions, please let me know.
yuvalmo
commented
Aug 3, 2023
Added unit tests as well.
Also removed redundant `easing` argument in call to `animate`. It wasn't really needed for this particular test.
yuvalmo
force-pushed
the
fix-animation-of-offset-with-tuple-and-string
branch
from
f7581d0 to
a839308
Compare
yuvalmo
changed the title
…on-of-offset-with-tuple-and-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3028 by doing to needed conversion from tuple / str into
ScalarOffsetso offset can be animated in an intuitive way.Please review the following checklist.
I am not sure which docs, if any, should be updated.
The bug page states that this is the expected behavior, so maybe the documentation already matches this PR?