Merge pull request #3595 from Textualize/pre-commit

Add more pre-commit hooks.

Author: rodrigogiraoserrao

.pre-commit-config.yaml

@@ -4,10 +4,18 @@ repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.3.0
     hooks:
-      - id: trailing-whitespace
-      - id: end-of-file-fixer
-      - id: check-yaml
-        args: [ '--unsafe' ]
+      - id: check-ast  # simply checks whether the files parse as valid python
+      - id: check-builtin-literals  # requires literal syntax when initializing empty or zero python builtin types
+      - id: check-case-conflict  # checks for files that would conflict in case-insensitive filesystems
+      - id: check-merge-conflict  # checks for files that contain merge conflict strings
+      - id: check-json  # checks json files for parseable syntax
+      - id: check-toml  # checks toml files for parseable syntax
+      - id: check-yaml  # checks yaml files for parseable syntax
+        args: [ '--unsafe' ]  # Instead of loading the files, simply parse them for syntax.
+      - id: check-shebang-scripts-are-executable  # ensures that (non-binary) files with a shebang are executable
+      - id: check-vcs-permalinks  # ensures that links to vcs websites are permalinks
+      - id: end-of-file-fixer  # ensures that a file is either empty, or ends with one newline
+      - id: mixed-line-ending  # replaces or checks mixed line ending
   - repo: https://github.com/pycqa/isort
     rev: 5.12.0
     hooks:
@@ -19,4 +27,9 @@ repos:
     rev: 23.1.0
     hooks:
       - id: black
+  - repo: https://github.com/hadialqattan/pycln  # removes unused imports
+    rev: v2.3.0
+    hooks:
+      - id: pycln
+        args: [--all]
 exclude: ^tests/snapshot_tests

docs/blog/snippets/2022-12-07-responsive-app-background-task/nonblocking01.py

@@ -1,5 +1,4 @@
 import asyncio
-import time
 from random import randint
 
 from textual.app import App, ComposeResult

docs/examples/events/on_decorator01.py

@@ -1,4 +1,3 @@
-from textual import on
 from textual.app import App, ComposeResult
 from textual.widgets import Button
 

docs/examples/events/prevent.py

@@ -1,5 +1,4 @@
 from textual.app import App, ComposeResult
-from textual.containers import Horizontal
 from textual.widgets import Button, Input
 
 

docs/examples/guide/reactivity/validate01.py

@@ -30,7 +30,7 @@ def on_button_pressed(self, event: Button.Pressed) -> None:
             self.count += 1
         else:
             self.count -= 1
-        self.query_one(RichLog).write(f"{self.count=}")
+        self.query_one(RichLog).write(f"count = {self.count}")
 
 
 if __name__ == "__main__":

docs/examples/styles/padding_all.py

@@ -1,5 +1,5 @@
 from textual.app import App
-from textual.containers import Container, Grid
+from textual.containers import Grid
 from textual.widgets import Placeholder
 
 

docs/examples/widgets/content_switcher.py

@@ -1,5 +1,3 @@
-from rich.align import VerticalCenter
-
 from textual.app import App, ComposeResult
 from textual.containers import Horizontal, VerticalScroll
 from textual.widgets import Button, ContentSwitcher, DataTable, Markdown

src/textual/_parser.py

@@ -165,8 +165,6 @@ def parse(
 
     test_parser = TestParser()
 
-    import time
-
     for n in range(0, len(data), 5):
         for token in test_parser.feed(data[n : n + 5]):
             print(token)

src/textual/_types.py

@@ -1,12 +1,6 @@
 from typing import TYPE_CHECKING, Any, Awaitable, Callable, List, Union
 
-from typing_extensions import (
-    Literal,
-    Protocol,
-    SupportsIndex,
-    get_args,
-    runtime_checkable,
-)
+from typing_extensions import Protocol
 
 if TYPE_CHECKING:
     from rich.segment import Segment

src/textual/css/_style_properties.py

@@ -47,7 +47,7 @@
 
 if TYPE_CHECKING:
     from .._layout import Layout
-    from .styles import Styles, StylesBase
+    from .styles import StylesBase
 
 from .types import AlignHorizontal, AlignVertical, DockEdge, EdgeType
 

src/textual/document/_document.py

@@ -5,12 +5,13 @@
 from functools import lru_cache
 from typing import TYPE_CHECKING, NamedTuple, Tuple, overload
 
+from typing_extensions import Literal, get_args
+
 if TYPE_CHECKING:
     from tree_sitter import Node
     from tree_sitter.binding import Query
 
 from textual._cells import cell_len
-from textual._types import Literal, get_args
 from textual.geometry import Size
 
 Newline = Literal["\r\n", "\n", "\r"]

src/textual/drivers/_input_reader_linux.py

@@ -4,8 +4,6 @@
 from threading import Event
 from typing import Iterator
 
-from textual import log
-
 
 class InputReader:
     """Read input from stdin."""

src/textual/drivers/linux_driver.py

@@ -14,7 +14,7 @@
 import rich.repr
 import rich.traceback
 
-from .. import events, log
+from .. import events
 from .._xterm_parser import XTermParser
 from ..driver import Driver
 from ..geometry import Size

src/textual/message_pump.py

@@ -26,7 +26,6 @@
 from ._context import prevent_message_types_stack
 from ._on import OnNoWidget
 from ._time import time
-from ._types import CallbackType
 from .case import camel_to_snake
 from .css.match import match
 from .errors import DuplicateKeyHandlers

src/textual/widgets/_tabs.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import asyncio
-from asyncio import create_task
 from dataclasses import dataclass
 from typing import ClassVar
 

src/textual/widgets/_text_area.py

@@ -9,6 +9,7 @@
 
 from rich.style import Style
 from rich.text import Text
+from typing_extensions import Literal, Protocol, runtime_checkable
 
 from textual._text_area_theme import TextAreaTheme
 from textual._tree_sitter import TREE_SITTER
@@ -30,11 +31,9 @@
 
 if TYPE_CHECKING:
     from tree_sitter import Language
-    from tree_sitter.binding import Query
 
 from textual import events, log
 from textual._cells import cell_len
-from textual._types import Literal, Protocol, runtime_checkable
 from textual.binding import Binding
 from textual.events import Message, MouseEvent
 from textual.geometry import Offset, Region, Size, Spacing, clamp

tests/css/test_programmatic_style_changes.py

@@ -2,7 +2,6 @@
 
 from textual.app import App
 from textual.containers import Grid
-from textual.screen import Screen
 from textual.widgets import Label
 
 

tests/css/test_stylesheet.py

@@ -1,5 +1,4 @@
 from contextlib import nullcontext as does_not_raise
-from typing import Any
 
 import pytest
 

tests/input/test_input_validation.py

@@ -2,7 +2,6 @@
 
 from textual import on
 from textual.app import App, ComposeResult
-from textual.events import Blur
 from textual.validation import Number, ValidationResult
 from textual.widgets import Input
 

tests/test_reactive.py

@@ -298,8 +298,6 @@ class Secondary(Primary):
     class Tertiary(Secondary):
         baz = reactive("baz")
 
-    from rich import print
-
     primary = Primary()
     secondary = Secondary()
     tertiary = Tertiary()

tests/test_screens.py

@@ -6,10 +6,10 @@
 
 from textual import work
 from textual.app import App, ComposeResult, ScreenStackError
-from textual.events import MouseMove, MouseScrollDown, MouseScrollUp
+from textual.events import MouseMove
 from textual.geometry import Offset
 from textual.screen import Screen
-from textual.widgets import Button, DataTable, Input, Label
+from textual.widgets import Button, Input, Label
 from textual.worker import NoActiveWorker
 
 skip_py310 = pytest.mark.skipif(

tests/test_style_inheritance.py

@@ -1,5 +1,3 @@
-from rich.style import Style
-
 from textual.app import App, ComposeResult
 from textual.widgets import Button, Static