Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an appropriate value for TERM_PROGRAM and TERM_PROGRAM_VERSION #10

Open
davep opened this issue Aug 31, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@davep
Copy link
Contributor

davep commented Aug 31, 2023

Currently, if someone was to use logic similar to textual diagnose, to diagnose what terminal their application was being run under, it would appear to be whatever terminal was used to run textual-web itself1. I feel it would be a good idea to set TERM_PROGRAM to textual-web and TERM_PROGRAM_VERSION to textual-web's version (or perhaps something appropriate to the terminal served to the client side; but that could get tricker as the service expands and potentially other clients could be used).

Footnotes

  1. Testing here, I ran textual-web, served a terminal with it, and the in-browser terminal had an environment that thought it was kitty.

@davep davep added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant