Milliseconds in RichHandler timestamps

[finnhughes]

Hi, I'm new to this fantastic looking library, thanks.

I want to use RichHandler for logging and like milliseconds in my timestamps. For now I've specified datefmt='%H:%M:%S.%f' but I'd prefer not to have microseconds. In the python formatter if you don't specify datefmt you get milliseconds by default but that's not possible with RichHandler. With the python formatter you can embed the timestamp in the message but then RichHandler doesn't recognise it as a timestamp anymore.

I had a quick look to see if there was something I could easily override but my best guess was overriding the LogRender call dunder function and that didn't feel very tidy.

Any thoughts?

[willmcgugan]

Rich uses datetime.strftime to format timestamps, but it doesn't look like that supports milliseconds (surprisingly). If you can't live without it, file a feature requests. No promises on timescale. Of course, if you think you could tackle it yourself I'd accept a PR...

[finnhughes]

Presumably that means adding a time_format argument to RichHandler to mirror the one in Console?

[willmcgugan]

log_time = datetime.fromtimestamp(record.created) + timedelta(microseconds=1000 * record.msecs)

Do you need to do this? Docs say created is a float as returned from time.time() which means it should contain full resolution.

Presumably that means adding a time_format argument to RichHandler to mirror the one in Console?

Makes sense.

[finnhughes]

Good point I don't think I need to, it was just logging handling milliseconds separately that confused me.

I think it's easier to handle in _log_render.py if the callable just returns a str rather than Text. It lets _log_render.py handle the conversion to Text and not duplicating timestamps in the way it already does?

[finnhughes]

This PR looks a lot cleaner though trying to describe the two options for log_time_format in one line is a bit tricky.

[finnhughes]

Thanks again for reviews and suggestions, if the current PR isn't it, it should be very close.

Your really helpful suggestions mean it looks a lot better now 👏