-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reused option name: -j is used for both JSON and emoji options #73
Comments
Well spotted! 😄 I would like to point out, however, that one might argue for doing this the other way round. Since Personally I actually prefer your breaking change since JSON is a lot more common for me than console markup with emoji codes... But I would like to mention this alternative for the sake of completeness. |
I agree, using |
The
-j
option name is listed for both the "Display as JSON" and "Enable emoji code" options in the code and documentation (including the splash screen image in the README). Click's option decorator silently allows one to overwrite the other. As a result, the JSON display option currently has no single-letter option name. To use it, one has to call--json
.Since the JSON option is older than the emoji option, I propose capitalizing the single-letter emoji option to
-J
. This would be a breaking change. I'll submit a PR for you to consider if this seems like a good approach.The text was updated successfully, but these errors were encountered: