Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML front matter #15

Closed
minimaxir opened this issue Apr 30, 2023 · 6 comments · Fixed by #96
Closed

YAML front matter #15

minimaxir opened this issue Apr 30, 2023 · 6 comments · Fixed by #96
Assignees
@davep
Labels
enhancement New feature or request Textual Issue Issues that are really down to how Textual works

Comments

@minimaxir
Copy link

YAML front matter is a common feature for static site/blog generators and Python documentation tools, but frogmouth handles it weirdly. Unclear if it's within scope.

The front matter for one of my blog posts in VS Code:

Screenshot 2023-04-30 at 2 10 50 PM

The front matter in frogmouth:

Screenshot 2023-04-30 at 2 05 12 PM
@davep
Copy link
Contributor

davep commented Apr 30, 2023

At this stage we're aiming to handle documents that conform to CommonMark, or thereabouts. But I can see that it would be handy to see about handling this too; I'll keep this in mind.

This was referenced May 1, 2023
Open
Closed
@davep davep added the enhancement New feature or request label May 1, 2023
@davep davep self-assigned this May 1, 2023
@willmcgugan
Copy link
Contributor

This should probably be something supported by the Textual Markdown widget.

@davep
Copy link
Contributor

davep commented May 1, 2023

@willmcgugan Yup, experimented with it briefly this morning and have it working; albeit by "ignoring" the front-matter for now; hence Textualize/textual#2440.

@davep
Copy link
Contributor

davep commented May 1, 2023

See also #20 for a more general take on this (eg: footnotes could be handy, etc).

@davep davep added the Textual Issue Issues that are really down to how Textual works label Jun 9, 2023
@davep
Copy link
Contributor

davep commented Jun 21, 2023

Now that Textualize/textual#2803 is part of Textual it should be easy enough to pull in the relevant plugin and make use of it.

@davep davep added the todo candidate Issues that are candidates for being up next to do label Jul 24, 2023
davep added a commit that referenced this issue Mar 26, 2024
@davep
Ignore frontmatter when viewing markdown documents
53784d5 
Fixes #15
@davep davep removed the todo candidate Issues that are candidates for being up next to do label Mar 26, 2024
@davep davep mentioned this issue Mar 26, 2024
Merged
@davep davep closed this as completed in #96 Mar 26, 2024
@davep
Copy link
Contributor

davep commented Mar 26, 2024

As of #96 frontmatter won't be displayed within the document view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
enhancement New feature or request Textual Issue Issues that are really down to how Textual works
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore frontmatter when viewing markdown documents Textualize/frogmouth
3 participants
@davep @willmcgugan @minimaxir