Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it good to have a text tool bar for the throwaway filter texts? #110

Open
elmarlee opened this issue Aug 4, 2023 · 3 comments
Open

Comments

@elmarlee
Copy link

elmarlee commented Aug 4, 2023

Thanks for the handy tool, it helped me a lot!
Besides the most useful filters which can be saved as .tat files, there are some throwaway filter texts which may only be helpful for the current log file. I feel it is helpful to have a quick filter for those throwaway filter texts.
My thought is to add a textbox control at the right of the menus. Then the user can input any regexp string, and then the tool shows the filtered lines in real time.
Right now we have to add a new filter, input the conditions then click ok to close "Add Filter" window, then check the results.
Is it a good idea?

@elmarlee
Copy link
Author

elmarlee commented Aug 4, 2023

Here is an example:
RealtimeFilter

@vincec-msft
Copy link

I'm not sure how much easier this is versus the current steps: Ctrl+N, type filter, hit Return. The only difference is clicking with the mouse vs. typing Ctrl+N. Am I missing something?

@elmarlee
Copy link
Author

elmarlee commented Aug 9, 2023

Thanks for Ctrl+N, I didn't pay attention to it before.
hmm...There is one major difference: For the new enhancement, the filtered result will be updated in real time when the user types so he may modify the filter text repeatedly. Ctrl+N almost assumes the user already knows his filter text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants