Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new results file for each test #126

Closed
mjurkus opened this issue Jan 27, 2021 · 3 comments
Closed

Create new results file for each test #126

mjurkus opened this issue Jan 27, 2021 · 3 comments
Labels
question Further information is requested

Comments

@mjurkus
Copy link

mjurkus commented Jan 27, 2021

Me and other users #124 (comment) ran into the issue, that tests file is reused and it's not immediately obvious.

I would suggest to have just a separate folder for test.tsv files and make it so each test has a separate file.

@nglehuy
Copy link
Collaborator

nglehuy commented Jan 27, 2021

@mjurkus You can use the argument to change file name:

parser.add_argument("--output_name", type=str, default="test",

You have to put a different file name when you want to test on another dataset, otherwise it will behave like resuming the test by counting the tested records, skip them and continue testing on untested records.

@nglehuy nglehuy added the question Further information is requested label Jan 27, 2021
@mjurkus
Copy link
Author

mjurkus commented Jan 28, 2021

parser.add_argument("--output_name", type=str, default="test", help="Result filename name prefix")

Ok. I didn't go into implementation for it but maybe it should be documented, that it will do that?

resuming the test by counting the tested records, skip them and continue testing on untested records

I too stepped on the same landmine in my experimentations.

@nglehuy
Copy link
Collaborator

nglehuy commented Apr 17, 2021

The testing scripts are updated and we have an option to overwrite or create a new test results. So I'll close this issue here 😄

@nglehuy nglehuy closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants