Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:保存流水线时校验引用到的子流水线权限 #10259

Open
fayewong-v5 opened this issue Apr 24, 2024 · 0 comments
Open

feat:保存流水线时校验引用到的子流水线权限 #10259

fayewong-v5 opened this issue Apr 24, 2024 · 0 comments
Assignees
Labels
for gray UAT environment in tencent has been deploy kind/enhancement 功能改进特性

Comments

@fayewong-v5
Copy link
Contributor

fayewong-v5 commented Apr 24, 2024

问题:
当运行子流水线时,需校验授权人是否有子流水线的执行权限。目前编辑流水线时,会更新流水线授权人,导致运行时无子流水线权限、失败。报错太靠后。

需求:
在保存流水线时,校验授权人是否有子流水线权限,如果没有权限,保存失败,提示如下:

用户[xxx]没有如下子流水线的执行权限,保存失败:

  • Stage[xxx]-Job[xxx]-Step[xxx]:<子流水线名称>

  • Stage[xxx]-Job[xxx]-Step[xxx]:<子流水线名称>

  • 子流水线名称点击可跳转至子流水线查看页面-权限管理 tab

注意:

  • 如果子流水线通过变量传入,变量有默认值,需校验默认值的权限
  • 如果子流水线通过名称方式引用,也需要校验对应的流水线权限
@fayewong-v5 fayewong-v5 added the kind/enhancement 功能改进特性 label Apr 24, 2024
@bkci-bot bkci-bot added the todo todo label May 9, 2024
mingshewhe added a commit to mingshewhe/bk-ci that referenced this issue May 10, 2024
revert,执行时已有日志埋点,不需要再埋点
@bkci-bot bkci-bot added for test Test environment in tencent has been deploy todo todo and removed todo todo labels May 13, 2024
@bkci-bot bkci-bot removed the todo todo label May 15, 2024
@mingshewhe mingshewhe added the tested 测试环境通过/test patest passed for test stage label May 15, 2024
bkci-bot added a commit that referenced this issue May 15, 2024
feat:保存流水线时校验引用到的子流水线权限 #10259
bkci-bot added a commit that referenced this issue May 15, 2024
feat:保存流水线时校验引用到的子流水线权限 #10259
@bkci-bot bkci-bot added for gray UAT environment in tencent has been deploy done Production environment in tencent has been deploy and removed for test Test environment in tencent has been deploy tested 测试环境通过/test patest passed for test stage for gray UAT environment in tencent has been deploy labels May 16, 2024
@bkci-bot bkci-bot added the todo todo label May 16, 2024
mingshewhe added a commit to mingshewhe/bk-ci that referenced this issue May 18, 2024
@bkci-bot bkci-bot added for test Test environment in tencent has been deploy and removed todo todo labels May 23, 2024
@mingshewhe mingshewhe reopened this May 23, 2024
@mingshewhe mingshewhe added tested 测试环境通过/test patest passed for test stage and removed for gray UAT environment in tencent has been deploy done Production environment in tencent has been deploy labels May 23, 2024
bkci-bot added a commit that referenced this issue May 23, 2024
feat:保存流水线时校验引用到的子流水线权限 #10259
@bkci-bot bkci-bot added for gray UAT environment in tencent has been deploy todo todo and removed for test Test environment in tencent has been deploy tested 测试环境通过/test patest passed for test stage labels May 23, 2024
mingshewhe added a commit to mingshewhe/bk-ci that referenced this issue May 27, 2024
@bkci-bot bkci-bot added for test Test environment in tencent has been deploy and removed todo todo labels May 27, 2024
@mingshewhe mingshewhe added the tested 测试环境通过/test patest passed for test stage label May 27, 2024
bkci-bot added a commit that referenced this issue May 27, 2024
feat:保存流水线时校验引用到的子流水线权限 #10259
@bkci-bot bkci-bot removed for test Test environment in tencent has been deploy tested 测试环境通过/test patest passed for test stage labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for gray UAT environment in tencent has been deploy kind/enhancement 功能改进特性
Projects
None yet
Development

No branches or pull requests

3 participants