Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX + AVX2 + FMA + AVX512 : Windows release does not support these instructions, please release windows precompiled versions for modern computers #74

Open
wonderingabout opened this issue Dec 14, 2018 · 7 comments

Comments

@wonderingabout
Copy link
Contributor

wonderingabout commented Dec 14, 2018

Can you release 2 windows releases for modern computers please ?

Computer from google cloud :
Windows Server 2016
Tesla V100
Intel Xeon Phi (supports AVX512F)

cpu instructionsv2

after that the games are played no problem,
but it is slower because no AVX / AVX2 / FMA / AVX512F

  • release 1 : supports AVX and AVX2 and FMA
  • release 2 : supports AVX512F (in linux it is supported by the compiler)

on ubuntu no problem to use these modern CPU instructions

Since tensorRT does not support batch size higher than 4, there is little benefit to use ubuntu instead of windows (harder to configure too)
So i think these 2 releases for windows and mac would be greatly appreciated 👍

can you make these 2 releases for windows (and mac) ?

big thanks ! @wodesuck

@wonderingabout wonderingabout changed the title AVX and AVX2 AVX512F : Windows release does not support these instructions AVX + AVX2 + AVX512F : Windows release does not support these instructions, please release windows precompiled versions for modern computers Dec 14, 2018
@wonderingabout wonderingabout changed the title AVX + AVX2 + AVX512F : Windows release does not support these instructions, please release windows precompiled versions for modern computers AVX + AVX2 + AVX512 : Windows release does not support these instructions, please release windows precompiled versions for modern computers Dec 16, 2018
@wodesuck
Copy link
Collaborator

I would try building an avx/avx2 version. But since I don't have any PC with avx512, you may need to build it yourself if really want.

@wonderingabout
Copy link
Contributor Author

wonderingabout commented Dec 17, 2018

avx/avx2 should cover most usages

for avx512, i use avx512 in ubuntu 16.04 after compiling with bazel, so no i dont need it
i just thought it was a good idea to add it

most important is avx/avx2 release for windows (and mac)

@wonderingabout
Copy link
Contributor Author

wonderingabout commented Dec 27, 2018

any update on avx/avx2 builds for windows and mac @wodesuck ?

@wodesuck
Copy link
Collaborator

wodesuck commented Jan 3, 2019

Not yet. I got some problem while building, but don't have time to fix it yet.

@wonderingabout
Copy link
Contributor Author

ok, when you try this again, can you also add fma too ?

(my r7 1700 has avx/avx2/fma support)

@wonderingabout wonderingabout changed the title AVX + AVX2 + AVX512 : Windows release does not support these instructions, please release windows precompiled versions for modern computers AVX + AVX2 + FMA + AVX512 : Windows release does not support these instructions, please release windows precompiled versions for modern computers Jan 3, 2019
@wonderingabout
Copy link
Contributor Author

@fiskerhuang @funionguo

@wonderingabout
Copy link
Contributor Author

wonderingabout commented Jan 7, 2019

some benchmark on my gtx1060 :

it is much slower than on ubuntu
here 3000 sims per move with default settings (all time manage settings disabled)

47s per move versus 21s per move on ubuntu with tensorrt (and arround 25s per move without tensorrt)

see :
avxv1
avxv2

compare it to my ubuntu benchmarks (4000 sims per move with same settings) here :
https://github.com/wonderingabout/PhoenixGo/blob/faqv2-bazel-master/docs/benchmark-gtx1060.md

i understand that it will take time, and i am not asking the developers to hurry,

but the windows release is indeed much slower than the linux release, due to the lack of avx avx2 fma (and possibly also because nvidia drivers are said to be arround 10% more powerful on ubuntu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants