Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Not referencing the original runsvc.sh causes problems when runsvc.sh changes #50

Open
farseeker opened this issue Aug 28, 2023 · 0 comments · May be fixed by #51
Open

Not referencing the original runsvc.sh causes problems when runsvc.sh changes #50

farseeker opened this issue Aug 28, 2023 · 0 comments · May be fixed by #51

Comments

@farseeker
Copy link

farseeker commented Aug 28, 2023

In configure_install_runner.sh runsvc.sh is copied into the root of the runner directory, and is never copied again if the upstream file changes.

That copied runsvc.sh is then referenced in github-actions-runner.service.epp.

Sometime in the past Github updated runsvc.sh to point to a different node version, which then breaks any runner using this Puppet module once the static node version is removed.

Either configure_install_runner.sh should be updated to check if the contents of the file has changed and copy it again if it has, or the unit file should be configured to reference the original non-copied location for runsvc.sh

@farseeker farseeker linked a pull request Aug 28, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant