-
Notifications
You must be signed in to change notification settings - Fork 15
fix(Buttons, Chips, Tags, Sheets, Snackbar): Remove label truncation #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 94609cf. |
|
Screenshot tests report ✔️ All passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buttonLink chevron is quite difficult to solve in this moment. @aweell and I consider to go forward with this PR although this case is not solved properly, but we are solving accessibility issues and this problem is just aesthetic

|
webapp screenshots impact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get why other screenshots of tables change since the tags now can be higher, but this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the old one you can see ellipsis. This happens becauuse the column is very narrow
Try reducing the width in this story and you can see the same as the screenshot
https://mistica-6vauh9y0v-flows-projects-65bb050e.vercel.app/?path=/story/components-table--default

Note
Already communicated to the OB