Skip to content

Conversation

@yceballost
Copy link
Contributor

@yceballost yceballost commented Jun 27, 2025

Note

Already communicated to the OB

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Size stats

master this branch diff
Total JS 12.5 MB 12.5 MB -160 B
JS without icons 2.16 MB 2.16 MB -160 B
Lib overhead 85.7 kB 85.7 kB -1 B
Lib overhead (gzip) 18.5 kB 18.5 kB +1 B

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-6vauh9y0v-flows-projects-65bb050e.vercel.app

Built with commit 94609cf.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Screenshot tests report

✔️ All passing

Copy link
Contributor Author

@yceballost yceballost Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These token changes are to avoid these cases when the text size increase

image

Copy link
Contributor Author

@yceballost yceballost Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttonLink chevron is quite difficult to solve in this moment. @aweell and I consider to go forward with this PR although this case is not solved properly, but we are solving accessibility issues and this problem is just aesthetic
image

@yceballost yceballost marked this pull request as ready for review July 1, 2025 18:19
@yceballost yceballost requested review from atabel and aweell July 2, 2025 08:57
@yceballost
Copy link
Contributor Author

webapp screenshots impact
https://github.com/Telefonica/webapp/actions/runs/15929915223

@yceballost yceballost changed the title fix(Buttons, Chips, Tags): Remove label truncation fix(Buttons, Chips, Tags, Sheets, Snackbar): Remove label truncation Sep 1, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why other screenshots of tables change since the tags now can be higher, but this one?

Copy link
Contributor Author

@yceballost yceballost Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old one you can see ellipsis. This happens becauuse the column is very narrow

Try reducing the width in this story and you can see the same as the screenshot
https://mistica-6vauh9y0v-flows-projects-65bb050e.vercel.app/?path=/story/components-table--default

@yceballost yceballost requested a review from aweell September 15, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants