fix: MOVES-10042 screenreader after animations #1358
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierfdezcast
changed the title
|
Size stats
|
|
Accessibility report ❌ 2 problems detectedpatterns-feedback-successfeedback--success (1 violations)patterns-feedback-successfeedback--success-as-header (1 violations)ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit b1a5a74. |
anabelengp
reviewed
May 19, 2025
| }: AssetFeedbackProps): JSX.Element => { | ||
| useHapticFeedback('success'); | ||
| const {skinName, platformOverrides} = useTheme(); | ||
| const [isShouldRead, setShouldRead] = React.useState(false); |
There was a problem hiding this comment.
should the initial state depend on areAnimationsSupported?
| <div | ||
| className={classnames(animateText && styles.feedbackTextAppearMedium)} | ||
| data-testid="description" | ||
| aria-hidden={hideOthers} |
There was a problem hiding this comment.
why do these divs need to be hiden?they are also animated
There was a problem hiding this comment.
they are hidden because if not, the screen reader reads then before the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.