-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixedToTop #1080
Labels
enhancement
New feature or request
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implementation
The ThemeContextProvider accepts to configure the dimensions of the
NavigationBar
:But these dimensions are not being used by the
NavigationBar
componentThere is a context named
FixedToTop
that allows to set the height of the elements that are being placed to the top (like aNavigationBar
) but theNavigationBar
component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51
Possible improvements
NavigationBar
component should set its height according to thedimensions
value from the themeNavigationBar
component should set theFixedToTop
context valueThe text was updated successfully, but these errors were encountered: