[FIX] dms: Delete the file if the attachment is deleted

When deleting an attachment, an attempt should be made to delete the linked file, causing an error if it is locked.
Do not show the Delete/Archive/Unarchive option on files if it is locked and you cannot unlock it.

Fixes OCA#381

Author: victoralmau

dms/models/dms_file.py

@@ -202,6 +202,7 @@ def check_access_token(self, access_token=False):
         prefetch=False,
         invisible=True,
         ondelete="cascade",
+        index=True,
     )
 
     def get_human_size(self):

dms/models/ir_attachment.py

@@ -1,4 +1,4 @@
-# Copyright 2021 Tecnativa - Víctor Martínez
+# Copyright 2021-2025 Tecnativa - Víctor Martínez
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
 from odoo import api, models
 from odoo.tools import ormcache
@@ -57,6 +57,7 @@ def _dms_operations(self):
                 )
             ):
                 continue
+
             directories = attachment._get_dms_directories(
                 attachment.res_model, attachment.res_id
             )
@@ -100,3 +101,8 @@ def write(self, vals):
         ):
             self._dms_operations()
         return res
+
+    def unlink(self):
+        if not self.env.context.get("dms_file"):
+            self.env["dms.file"].search([("attachment_id", "in", self.ids)]).unlink()
+        return super().unlink()

dms/tests/test_storage_attachment.py

@@ -2,6 +2,7 @@
 # Copyright 2021 Tecnativa - João Marques
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
 
+from odoo.exceptions import AccessError
 from odoo.tests.common import users
 from odoo.tools import mute_logger
 
@@ -42,6 +43,26 @@ def test_storage_attachment_record_db_unlink(self):
         directories = self.env["dms.directory"].search([])
         self.assertNotIn(directory.id, directories.ids)
 
+    @mute_logger("odoo.models.unlink")
+    def test_storage_attachment_unlink_lock_file(self):
+        group_partner_manager = self.env.ref("base.group_partner_manager")
+        self.dms_manager_user.write({"groups_id": [(4, group_partner_manager.id)]})
+        self.dms_user.write({"groups_id": [(4, group_partner_manager.id)]})
+        attachment = self._create_attachment("demo.txt")
+        attachment = attachment.with_user(self.dms_manager_user)
+        file = self.storage.storage_file_ids.filtered(lambda x: x.name == "demo.txt")
+        file.with_user(self.dms_user).lock()
+        self.assertTrue(file.is_locked)
+        self.assertFalse(file.is_lock_editor)
+        with self.assertRaises(AccessError):
+            attachment.unlink()
+        self.assertTrue(file.exists())
+        file.with_user(self.dms_user).unlock()
+        self.assertFalse(file.is_locked)
+        file.invalidate_recordset()
+        attachment.unlink()
+        self.assertFalse(file.exists())
+
     @users("dms-manager")
     def test_storage_attachment_misc(self):
         attachment = self._create_attachment("demo.txt")

dms/views/dms_file.xml

@@ -152,7 +152,7 @@
                                                 Unlock
                                             </a>
                                             <a
-                                                t-if="record.permission_write.raw_value and record.active.raw_value"
+                                                t-if="record.permission_write.raw_value and record.active.raw_value and (!record.is_locked.raw_value or (record.is_locked.raw_value and record.is_lock_editor.raw_value))"
                                                 role="menuitem"
                                                 name="toggle_active"
                                                 type="object"
@@ -162,7 +162,7 @@
                                                 Archive
                                             </a>
                                             <a
-                                                t-if="record.permission_write.raw_value and !record.active.raw_value"
+                                                t-if="record.permission_write.raw_value and !record.active.raw_value and (!record.is_locked.raw_value or (record.is_locked.raw_value and record.is_lock_editor.raw_value))"
                                                 role="menuitem"
                                                 name="toggle_active"
                                                 type="object"
@@ -204,7 +204,7 @@
                                                 Edit
                                             </a>
                                             <a
-                                                t-if="record.permission_unlink.raw_value"
+                                                t-if="record.permission_unlink.raw_value and (!record.is_locked.raw_value or (record.is_locked.raw_value and record.is_lock_editor.raw_value))"
                                                 role="menuitem"
                                                 type="delete"
                                                 class="dropdown-item"