-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the dict
response in load_existing_datasets
with a Pydantic class
#85
Comments
Hi! I'm pretty new to Python and was looking for good first issues to tackle. Was curious to know why you would use a Pydantic class here rather than a simple dataclass for this? |
Hey @cosmastech, a simple dataclass could work just as well! If you're looking to contribute - awesome! I can create a couple of issues that are good starter issues to get to grips with the codebase. I'll tag you in them when I've put them up. |
Cool! Thanks. |
Could you please have a look at this one? @cosmastech |
We should avoid passing loosely typed dictionaries around if we can avoid it. This should be replaced by a Pydantic class.
Note: This is in
BufferedLogger
.The text was updated successfully, but these errors were encountered: