Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default space "active" #3487

Open
ModProg opened this issue Jan 9, 2025 · 6 comments
Open

Make default space "active" #3487

ModProg opened this issue Jan 9, 2025 · 6 comments
Labels
enhancement New feature or request

Comments

@ModProg
Copy link

ModProg commented Jan 9, 2025

Is your feature request related to a problem? Please describe.

I want new users immediately on the search page, bypassing the spaces overview.

Describe the solution you'd like

Addd an option to set the default space (SOCIAL_DEFAULT_ACCESS) to active upon signup:

user_space = UserSpace.objects.create(space=Space.objects.first(), user=request.user, active=False)

Describe alternatives you've considered

Somehow detect first login through traefik/nginx midleware and redirect to /switch-space/1

Additional context

No response

@ModProg ModProg added the enhancement New feature or request label Jan 9, 2025
@smilerz
Copy link
Collaborator

smilerz commented Jan 9, 2025

what do you mean recipe overview page? the index page is search

@ModProg
Copy link
Author

ModProg commented Jan 9, 2025

Sorry meant spaces overview.

@ModProg
Copy link
Author

ModProg commented Jan 9, 2025

I was thinking something like this could work:
develop...ModProg:recipes:patch-1

@smilerz
Copy link
Collaborator

smilerz commented Jan 9, 2025

it would need to be something like DEFAULT_LANDING_PAGE or something, and that wouldn't be sufficient. you'd need to add logic to detect that it is a new user and redirect them to page based on a Space setting.

Not sure if @vabene1111 is interested in adding that level of customization. I'm not convinced it's necessary or desirable, but it's his call.

@ModProg
Copy link
Author

ModProg commented Jan 9, 2025

AFAICT, once there is an active Space, the user will be redirected there automatically… that's why I posed this issue as I did.

If my assumption is wrong, then this might be more complex.

@smilerz
Copy link
Collaborator

smilerz commented Jan 9, 2025

Space is a tenant boundary.
SOCIAL_DEFAULT_ACCESS allows the host provider to automatically add social logins to a specific space (useful in single-tenant implementations)
redirecting users based on 'newness' on a per-space level is something very different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants