Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cup missing from base unit conversions #3258

Open
PeterAttardo opened this issue Aug 12, 2024 · 1 comment
Open

Cup missing from base unit conversions #3258

PeterAttardo opened this issue Aug 12, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@PeterAttardo
Copy link

Tandoor Version

1.5.18

Setup

Docker / Docker-Compose

Reverse Proxy

No reverse proxy

Other

No response

Bug description

I noticed that nutrition information was not being calculated for certain foods in my recipes. I eventually figured out that it was because the quantities were specified in tbsp in the recipe, but the conversion for that food was cup <-> g, and tandoor was failing to automatically handle the tbsp <-> cup conversion. Looking at the code, it appears that cup is missing from the conversion table constant. Given its prevalence in US recipes, I think cup should be a base volume unit, and it appears it was considered as such in the initial proposal. It may have been overlooked during implementation.

Relevant logs

No response

@vabene1111
Copy link
Collaborator

I think you are right, cup is a basic volumetric unit, even tough it varies strongly depending on region but still, it should be in there.

@vabene1111 vabene1111 added this to the 1.5.0 milestone Aug 13, 2024
@vabene1111 vabene1111 added the enhancement New feature or request label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants