-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SECRET_KEY_FILE env variable is not used properly #3075
Comments
I think the decision to use boot sh was made by whoever contributed this pit of ease of implementation. I would prefer to document this behavior for now. The system itself should not be changed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tandoor Version
1.5.6
Setup
Others (please state below)
Reverse Proxy
Others (please state below)
Other
NixOS Tandoor module and custom Nginx
Bug description
According to the configuration option documentation, I am able to point Tandoor at a SECRET_KEY_FILE instead of setting the secret key directly. However, this does only work when using the boot.sh script provided in the Tandoor repository. If users choose to configure Tandoor differently, for example via the NixOS Tandoor module which uses a custom systemd service (similar as to the one described here, the SECRET_KEY_FILE variable is ignored. Either Tandoor should detect this variable and read from the file directly (and therefore not rely on the boot.sh script) or the documentation should explain this behaviour, if it is intentional.
If this is not intentional and this should be changed, I would be able to make the necessary changes myself and create a PR.
Relevant logs
No response
The text was updated successfully, but these errors were encountered: