Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error #1513

Closed
andelkocvjetkovic opened this issue Apr 24, 2024 · 6 comments
Closed

Uncaught Error #1513

andelkocvjetkovic opened this issue Apr 24, 2024 · 6 comments
Labels
question This issue is about a user needing insight

Comments

@andelkocvjetkovic
Copy link

andelkocvjetkovic commented Apr 24, 2024

Describe the bug

When an error is thrown within the loader, "Uncaught Error" appears in my browser console, even though the error page is shown.

Your Example Website or App

https://stackblitz.com/edit/tanstack-router-zz3epc?file=src%2Fposts.tsx

Steps to Reproduce the Bug or Issue

  1. Click on Post 1.
  2. Open browser console and observe "Uncaught Error"
chunk-WM253HRZ.js?v=5f883516:1114 Uncaught Error at posts.tsx:15:20

Expected behavior

I expect to the error within loader to be caught and clean console in my browser

Screenshots or Videos

Screenshot 2024-04-24 at 11 25 34

Platform

  • OS: macOS
  • Browser: Chrome
  • Version: 123.0.6312.124

Additional context

No response

@hugocostadev
Copy link
Contributor

hugocostadev commented Apr 25, 2024

check this issue, maybe it's the same...

#1480

@andelkocvjetkovic
Copy link
Author

andelkocvjetkovic commented Apr 25, 2024

I'm on "@tanstack/react-router": "1.28.1", so I don't think it is related

@andelkocvjetkovic
Copy link
Author

The issue is present in "@tanstack/react-router": "1.31.1" as well

@SeanCassiere
Copy link
Contributor

SeanCassiere commented May 2, 2024

A couple of questions:

  1. Just to be clear, the issue here is that we are logging the error to the console?
  2. Why is logging the error to the console bad?

It's important to remember that this is client-sided, so there's no chance of SECRETS being revealed. Also, you'll only ever get here when there has been an error and the errorComponent has been triggered, and by default,errors are always printed to the console.

We'd need a valid reason to change this behaviour since some users have hooks that use the output of the console and that this isn't a show-stopping problem or a bug. Its currently, the intended behaviour.

@SeanCassiere SeanCassiere added the information needed Further information is requested label May 2, 2024
@andelkocvjetkovic
Copy link
Author

My question is why I'm getting an 'Uncaught Error' in my console. Is this something I should take care of, and how precisely should I handle this?

Thanks.

@SeanCassiere
Copy link
Contributor

@andelkocvjetkovic this isn't something that requires intervention from you. No further error handling is required on your-part.

Very simply, the Error is printed out to the console since the application has encountered an error (intentional or not). You can choose to customize how you display the Error to the user using the errorComponent, but nevertheless an Error has occurred. As such, the error is printed to the console.

@SeanCassiere SeanCassiere added question This issue is about a user needing insight and removed information needed Further information is requested labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This issue is about a user needing insight
Projects
None yet
Development

No branches or pull requests

3 participants