fix(react-start-client): useServerFn returns a stable reference (#4647)

Author: timreinke

packages/react-start-client/src/useServerFn.ts

@@ -1,3 +1,4 @@
+import * as React from 'react'
 import { isRedirect } from '@tanstack/router-core'
 import { useRouter } from '@tanstack/react-router'
 
@@ -6,22 +7,25 @@ export function useServerFn<T extends (...deps: Array<any>) => Promise<any>>(
 ): (...args: Parameters<T>) => ReturnType<T> {
   const router = useRouter()
 
-  return (async (...args: Array<any>) => {
-    try {
-      const res = await serverFn(...args)
+  return React.useCallback(
+    async (...args: Array<any>) => {
+      try {
+        const res = await serverFn(...args)
 
-      if (isRedirect(res)) {
-        throw res
-      }
+        if (isRedirect(res)) {
+          throw res
+        }
 
-      return res
-    } catch (err) {
-      if (isRedirect(err)) {
-        err.options._fromLocation = router.state.location
-        return router.navigate(router.resolveRedirect(err).options)
-      }
+        return res
+      } catch (err) {
+        if (isRedirect(err)) {
+          err.options._fromLocation = router.state.location
+          return router.navigate(router.resolveRedirect(err).options)
+        }
 
-      throw err
-    }
-  }) as any
+        throw err
+      }
+    },
+    [router, serverFn],
+  ) as any
 }