Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws a TypeError when service worker not supported #119

Open
gavmck opened this issue Dec 13, 2017 · 0 comments
Open

Throws a TypeError when service worker not supported #119

gavmck opened this issue Dec 13, 2017 · 0 comments

Comments

@gavmck
Copy link

gavmck commented Dec 13, 2017

Expected Behavior

UpUp.start should fail silently when not supported.

Current Behavior

Throws an error: TypeError: null is not an object (evaluating 'UpUp.start')

Possible Solution

Still return an object from UpUp so you can call UpUp.start without it exploding.

Context

We catch JS errors in our app and forward to /error, which tries to load upup which causes a js error which forwards to /error in an infinite loop

Your Environment

  • Version used: 0.3.0
  • Browser Name and version: Safari 11.0.2
  • Operating System and version (desktop or mobile): OSX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant