[TASK] Update bash syntax for variables and conditions

Author: sgrossberndt

templates/pdns/pdns_errors

@@ -15,12 +15,12 @@
 
 command="/usr/bin/pdns_control list"
 
-if [ "$1" = "autoconf" ]; then
+if [[ "$1" = "autoconf" ]]; then
         echo yes
         exit 0
 fi
 
-if [ "$1" = "config" ]; then
+if [[ "$1" = "config" ]]; then
         echo 'graph_title Power DNS errors'
         echo 'graph_args -l 0 --base 1000'
         echo 'graph_vlabel numbers of'
@@ -41,5 +41,4 @@ if [ "$1" = "config" ]; then
         exit 0
 fi
 
-
-$command | sed 's/=\([0-9]\+\),/.value \1\n/g' | grep corrupt'\|'servfail'\|'timedout | sed 's/-/_/g'
+${command} | sed 's/=\([0-9]\+\),/.value \1\n/g' | grep corrupt'\|'servfail'\|'timedout | sed 's/-/_/g'

templates/pdns/pdns_latency

@@ -15,12 +15,12 @@
 
 command="/usr/bin/pdns_control show"
 
-if [ "$1" = "autoconf" ]; then
+if [[ "$1" = "autoconf" ]]; then
         echo yes
         exit 0
 fi
 
-if [ "$1" = "config" ]; then
+if [[ "$1" = "config" ]]; then
         echo 'graph_title Power DNS latency'
         echo 'graph_args -l 0'
         echo 'graph_vlabel usec'
@@ -32,7 +32,4 @@ if [ "$1" = "config" ]; then
         exit 0
 fi
 
-
-
-
-echo "latency.value $($command latency | awk -F= '{print $2}')"
+echo "latency.value $(${command} latency | awk -F= '{print $2}')"

templates/pdns/pdns_qsize

@@ -15,12 +15,12 @@
 
 command="/usr/bin/pdns_control show"
 
-if [ "$1" = "autoconf" ]; then
+if [[ "$1" = "autoconf" ]]; then
         echo yes
         exit 0
 fi
 
-if [ "$1" = "config" ]; then
+if [[ "$1" = "config" ]]; then
         echo 'graph_title Power DNS database queue'
         echo 'graph_args -l 0'
         echo 'graph_vlabel number of waiting queries'
@@ -32,5 +32,5 @@ if [ "$1" = "config" ]; then
         exit 0
 fi
 
-echo "qsize.value $($command qsize-q)"
+echo "qsize.value $(${command} qsize-q)"
 

templates/pdns/pdns_queries

@@ -15,12 +15,12 @@
 
 command="/usr/bin/pdns_control list"
 
-if [ "$1" = "autoconf" ]; then
+if [[ "$1" = "autoconf" ]]; then
         echo yes
         exit 0
 fi
 
-if [ "$1" = "config" ]; then
+if [[ "$1" = "config" ]]; then
         echo 'graph_title Power DNS queries'
         echo 'graph_args -l 0 --base 1000'
         echo 'graph_vlabel numbers of'
@@ -53,5 +53,4 @@ if [ "$1" = "config" ]; then
         exit 0
 fi
 
-
-$command | sed 's/=\([0-9]\+\),/.value \1\n/g' | grep udp-'\|'recursing'\|'tcp | sed 's/-/_/g'
+${command} | sed 's/=\([0-9]\+\),/.value \1\n/g' | grep udp-'\|'recursing'\|'tcp | sed 's/-/_/g'