Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lynx need to check cypher schema #127

Open
LianxinGao opened this issue Jul 6, 2022 · 3 comments
Open

Lynx need to check cypher schema #127

LianxinGao opened this issue Jul 6, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@LianxinGao
Copy link
Contributor

LianxinGao commented Jul 6, 2022

If a query like this:
"""
create (m)<-[r1: HAS_CREATOR]-(p1)
create (m)<-[r1: HAS_CREATOR]-(p2)
"""

we should throw a exception: "Variable r1 already declared"

but now, we can create relationship correctly, it seems the latter r1 will cover r1 before. But if the context want use the earlier r1, the logic will not be correct.

@LianxinGao LianxinGao changed the title cypher need to check schema Lynx need to check cypher schema Jul 6, 2022
@chunyang-wen
Copy link
Contributor

I think it is ok. Because a variable has its own scope. There are cases where users are making mistakes to reuse variable name, but there are cases where reusing variable are ok.

@LianxinGao
Copy link
Contributor Author

I think it is ok. Because a variable has its own scope. There are cases where users are making mistakes to reuse variable name, but there are cases where reusing variable are ok.

In neo4j,it will throw exception.

So it depends on our choice~

@chunyang-wen chunyang-wen self-assigned this Jul 7, 2022
@merlintang merlintang added the bug Something isn't working label Jul 8, 2022
@merlintang
Copy link
Contributor

any conclusion here, my option is that we can choose the neo4j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants