fix: remove noop playbook check

PaulFarault · PaulFarault · commit e2fdbbbe5e63 · 2024-10-23T12:09:24.000+02:00
diff --git a/tdp/core/dag.py b/tdp/core/dag.py
@@ -264,7 +264,6 @@ def validate_dag_nodes(nodes: Operations, collections: Collections) -> None:
     - \*_start operations can only be required from within its own service
     - \*_install operations should only depend on other \*_install operations
     - Each service (HDFS, HBase, Hive, etc) should have \*_install, \*_config, \*_init and \*_start operations even if they are "empty" (tagged with noop)
-    - Operations tagged with the noop flag should not have a playbook defined in the collection
     - Each service action (config, start, init) except the first (install) must have an explicit dependency with the previous service operation within the same service
     """
     # key: service_name
@@ -328,17 +327,6 @@ def warning(collection_name: str, message: str) -> None:
                         f"'{operation.service_name}_{previous_action}'"
                     )
 
-        # Operations tagged with the noop flag should not have a playbook defined in the collection
-
-        if operation_name in collections[operation.collection_name].playbooks:
-            if operation.noop:
-                c_warning(
-                    f"Operation '{operation_name}' is noop and the playbook should not exist"
-                )
-        else:
-            if not operation.noop:
-                c_warning(f"Operation '{operation_name}' should have a playbook")
-
     # Each service (HDFS, HBase, Hive, etc) should have *_install, *_config, *_init and *_start actions
     # even if they are "empty" (tagged with noop)
     # Part 2
diff --git a/tdp_vars/all b/tdp_vars/all
@@ -0,0 +1 @@
+Subproject commit f9f8dd04cacfefba637386a61957f73acccee8bd
diff --git a/tdp_vars/exporter b/tdp_vars/exporter
@@ -0,0 +1 @@
+Subproject commit fa2c2a16e74df9761ebed9b3009886c8e0167c63
diff --git a/tdp_vars/firewall b/tdp_vars/firewall
@@ -0,0 +1 @@
+Subproject commit d7c874bc1ee5a25c3e9c7a41be7b84ef0c75017f
diff --git a/tdp_vars/grafana b/tdp_vars/grafana
@@ -0,0 +1 @@
+Subproject commit b43d47d0cf461d1c41b06752ce929f0a0d4f236e
diff --git a/tdp_vars/hadoop b/tdp_vars/hadoop
@@ -0,0 +1 @@
+Subproject commit 119c1f40b14ae9518cd7b7d3a379947c67ee828e
diff --git a/tdp_vars/hbase b/tdp_vars/hbase
@@ -0,0 +1 @@
+Subproject commit 3e10aee671e8658f4ad3ca307c8fa347effead42
diff --git a/tdp_vars/hdfs b/tdp_vars/hdfs
@@ -0,0 +1 @@
+Subproject commit db2447b53c6f3a9dbf4d0f37c5d865352cba1e30
diff --git a/tdp_vars/hive b/tdp_vars/hive
@@ -0,0 +1 @@
+Subproject commit b1483a24a2198c305a6d80ddb4305fad2bd49fe5
diff --git a/tdp_vars/hue b/tdp_vars/hue
@@ -0,0 +1 @@
+Subproject commit e7cf21f1f1cfff5703b2d2cff9dbe8ad41a45457
diff --git a/tdp_vars/jupyterhub b/tdp_vars/jupyterhub
@@ -0,0 +1 @@
+Subproject commit 43610de21e1e851c40d0de0b3049527e7347047b
diff --git a/tdp_vars/kafka b/tdp_vars/kafka
@@ -0,0 +1 @@
+Subproject commit 282eb0666f03f9a03a9952386935b0f0d9521ad6
diff --git a/tdp_vars/knox b/tdp_vars/knox
@@ -0,0 +1 @@
+Subproject commit eaea2469a07637b2abaa0e9edc7ee7e15f4b6993
diff --git a/tdp_vars/livy b/tdp_vars/livy
@@ -0,0 +1 @@
+Subproject commit 0e088a3351cd027a173ef9c503f143413d8f8215
diff --git a/tdp_vars/livy-spark3 b/tdp_vars/livy-spark3
@@ -0,0 +1 @@
+Subproject commit 299ccdd3f3ebe7c8d3b9bb12ea8240d9f72ed4cb
diff --git a/tdp_vars/loki b/tdp_vars/loki
@@ -0,0 +1 @@
+Subproject commit 8c209b0ac6529430786874fae0af1a31621a5c31
diff --git a/tdp_vars/prometheus b/tdp_vars/prometheus
@@ -0,0 +1 @@
+Subproject commit acd9cd5b943bc3103056e4257842006353b67478
diff --git a/tdp_vars/ranger b/tdp_vars/ranger
@@ -0,0 +1 @@
+Subproject commit ac9c0718bb2ce68f223cda6e4ec48926934a934c
diff --git a/tdp_vars/spark b/tdp_vars/spark
@@ -0,0 +1 @@
+Subproject commit 3ff38c0ec4a0e8bf4aeaf2f9502f4e7d3cb1555c
diff --git a/tdp_vars/spark3 b/tdp_vars/spark3
@@ -0,0 +1 @@
+Subproject commit fe2f75d4a16e95554d945a5f71c6640dae13a474
diff --git a/tdp_vars/tdp-cluster b/tdp_vars/tdp-cluster
@@ -0,0 +1 @@
+Subproject commit 12636c9d5f072f2fb89ab4e2a13f01222c4d1d6c
diff --git a/tdp_vars/yarn b/tdp_vars/yarn
@@ -0,0 +1 @@
+Subproject commit b8bc35575f869aaee9161f3296504a0135c34abd
diff --git a/tdp_vars/zookeeper b/tdp_vars/zookeeper
@@ -0,0 +1 @@
+Subproject commit c68827cb41273b584536955187559bd548564133
diff --git a/tdp_vars/zookeeper-kafka b/tdp_vars/zookeeper-kafka
@@ -0,0 +1 @@
+Subproject commit 2955aa606a78eec45a4dceb1aecdd9c45b1344aa

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit f9f8dd04cacfefba637386a61957f73acccee8bd`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit fa2c2a16e74df9761ebed9b3009886c8e0167c63`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit d7c874bc1ee5a25c3e9c7a41be7b84ef0c75017f`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit b43d47d0cf461d1c41b06752ce929f0a0d4f236e`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 119c1f40b14ae9518cd7b7d3a379947c67ee828e`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 3e10aee671e8658f4ad3ca307c8fa347effead42`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit db2447b53c6f3a9dbf4d0f37c5d865352cba1e30`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit b1483a24a2198c305a6d80ddb4305fad2bd49fe5`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit e7cf21f1f1cfff5703b2d2cff9dbe8ad41a45457`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Subproject commit 43610de21e1e851c40d0de0b3049527e7347047b`