Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nova resource #43

Closed
wants to merge 1 commit into from
Closed

update nova resource #43

wants to merge 1 commit into from

Conversation

arwaawan3
Copy link

Closes #42

joshtorres
joshtorres approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@joshtorres joshtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@joshtorres
Copy link
Member

Please fix merge conflicts

@wolfrednicolas
Copy link
Contributor

wolfrednicolas commented May 20, 2021 •
edited

I'm going to close this PR since the composer is deprecated with conflicts and also are missing validations... the validation made here related to the permissions are gonna be in #46

I made this in order to see all the changes in one PR instead of multiples and getting green in the test

@wolfrednicolas wolfrednicolas mentioned this pull request May 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtorres joshtorres joshtorres approved these changes

@drewroberts drewroberts Awaiting requested review from drewroberts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update user permissions
4 participants
@arwaawan3 @joshtorres @wolfrednicolas @arwaawan