Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pg package to version 8 or allow ssl configuration? #28

Open
rosstroha opened this issue Apr 19, 2021 · 2 comments
Open

Update pg package to version 8 or allow ssl configuration? #28

rosstroha opened this issue Apr 19, 2021 · 2 comments

Comments

@rosstroha
Copy link

Hi there! First, thank you all for taking the time to create this package. It's a huge timesaver, even after dealing with a two day long problem I just figured out. My brain is still swimming with all the different variables and troubleshooting things I had tried, so I apologize if these suggested changes aren't your responsibility!

I'm using Heroku to host the bot and a Heroku Postgres addon. Heroku's documentation states that an ssl config object is needed, as seen here. The problem is that pg@8 is the version that allows one to do it in this exact way. See the breaking changes here. or, as an alternative, add an env var PGSSLMODE=no-verify. This env var only works if pg@8 is installed, apparently.

My problem was this: No connection was being made to the db through botbuilder-storage-postgres. There were no errors. I solved it by explicitly installing pg@8 as well as adding PGSSLMODE=no-verify because I didn't have access to the ssl configuration object through this package. As the lazy developer that I am I relied on pg being installed as a dependency of this package, which it is. However, it's one major version behind; the one that doesn't jive with PGSSLMODE.

  1. Could we be allowed to configure the ssl options?
    or
  2. Could this package be updated to use the latest and greatest pg@8?

Many thanks!

@rosstroha
Copy link
Author

rosstroha commented May 4, 2021

@roeintense

@bromeostasis
Copy link

@rosstroha I would also like to use pg@8 as it allows me to develop in node 14+. I'll probably just make a fork for now, but it'd be great if this could be officially supported.

@dfarinella-tda seems like the latest contributor to the project; is this possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants