Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for jwt.Sign() variadic parameter options #90

Open
KendallWeihe opened this issue Feb 28, 2024 · 1 comment
Open

Add unit test for jwt.Sign() variadic parameter options #90

KendallWeihe opened this issue Feb 28, 2024 · 1 comment

Comments

@KendallWeihe
Copy link
Contributor

Originally thought of while reviewing #89

We should add a test to jwt_test.go something like...

func TestSign_Options(t *testing.T) { ... }

Which will test the variadic parameter options. Type() will be easy to unit test but Purpose() not as straight forward because (I think?) we'll need to generate a DID with multiple keys and instruct the signing to occur on the non-default key (a lot of assumptions in that statement; just briefly looking at it, it's complicated enough to stub in a ticket to investigate)

@KendallWeihe
Copy link
Contributor Author

Probably we need unit tests for all our variadic parameter options all over the place, not just JWT. Feel free to use this ticket as a chance to create more tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant