Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign message / resource during Create() and nix Sign() method. #29

Open
jiyoontbd opened this issue Apr 23, 2024 · 2 comments · Fixed by #37
Open

Sign message / resource during Create() and nix Sign() method. #29

jiyoontbd opened this issue Apr 23, 2024 · 2 comments · Fixed by #37

Comments

@jiyoontbd
Copy link
Contributor

No description provided.

@jiyoontbd jiyoontbd mentioned this issue Apr 23, 2024
Merged
@mistermoe
Copy link
Member

@phoebe-lew phoebe-lew self-assigned this May 1, 2024
@phoebe-lew phoebe-lew mentioned this issue May 1, 2024
Merged
@mistermoe mistermoe mentioned this issue May 6, 2024
Merged
@diehuxx
Copy link
Contributor

diehuxx commented May 6, 2024

Re-opening after some discussion with @mistermoe:

The desire is actually to follow the pattern in #45, i.e.

  1. Add an option for .create() to sign the message
  2. Also have a distinct .sign() function

cc: @phoebe-lew

@diehuxx diehuxx reopened this May 6, 2024
@phoebe-lew phoebe-lew removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

close message + tests TBD54566975/tbdex-go
4 participants
@mistermoe @phoebe-lew @diehuxx @jiyoontbd