Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests use the system ftl instead of the local dev version #1481

Closed
deniseli opened this issue May 14, 2024 · 2 comments
Closed
Labels
good first issue Good for newcomers

Comments

@deniseli
Copy link
Contributor

If your integration tests depend on using a more recent FTL release than your homebrew installed version, then your tests will fail. Temporary workaround if you need the latest release is to brew upgrade ftl in your system, but we should fix this by having having the integration tests always use your local dev version.

@github-actions github-actions bot added the triage Issue needs triaging label May 14, 2024
@deniseli deniseli added good first issue Good for newcomers and removed triage Issue needs triaging labels May 14, 2024
@alecthomas
Copy link
Collaborator

This is not quite correct. The integration tests use whatever is in the $PATH, which will be the local development version of FTL if the Hermit environment is activated. What I suspect is happening in your case is that you're running the tests from inside VSCode, which doesn't preserve Hermit's $PATH under some circumstances.

@deniseli
Copy link
Contributor Author

Ahhhhh that makes sense. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants