Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the integrationtest framework to be used from anywhere #1384

Closed
alecthomas opened this issue May 2, 2024 · 0 comments · Fixed by #1593
Closed

Allow the integrationtest framework to be used from anywhere #1384

alecthomas opened this issue May 2, 2024 · 0 comments · Fixed by #1593
Assignees
@jonathanj-square
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented May 2, 2024 •
edited

Currently all tests must be in the integrationtest directory, but it would be much nicer if we could run integration tests from anywhere in the source tree, such that the tests for a particular package live alongside that package.

This should be relatively straightforward:

  1. Make the DSL an importable package rather than only visible to tests in the integrationtest package.
  2. Resolve any assumptions about location in the source tree.
  3. Update the GH workflow to find and run integration tests from anywhere.
@alecthomas alecthomas added the good first issue Good for newcomers label May 2, 2024
@github-actions github-actions bot added the triage Issue needs triaging label May 2, 2024
@alecthomas alecthomas mentioned this issue May 2, 2024
Open
@alecthomas alecthomas changed the title Allow the integrationtest framework to be used from anywhere Allow the integrationtest framework to be used from anywhere May 2, 2024
@worstell worstell removed the triage Issue needs triaging label May 2, 2024
@jonathanj-square jonathanj-square mentioned this issue May 28, 2024
Merged
jonathanj-square added a commit that referenced this issue May 30, 2024
@jonathanj-square
fix: allow integration tests to run from anywhere (#1593)
0381efa 
fixes #1384 

- exposes DSL steps as public for use in other packages
- modify the `integration test` just command to search for dirs
containing the integration test tag
@jonathanj-square jonathanj-square mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanj-square jonathanj-square

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow integration tests to run from anywhere TBD54566975/ftl
3 participants
@alecthomas @worstell @jonathanj-square