Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradient descent notebook #193

Open
KrisThielemans opened this issue Jan 23, 2023 · 8 comments
Open

gradient descent notebook #193

KrisThielemans opened this issue Jan 23, 2023 · 8 comments
Milestone

Comments

@KrisThielemans
Copy link
Member

the PET recon has a funny line
image

Also, it is called gradient descent, but it is actually ascending due to some minus signs. Better to switch the sign in the PET, but keep it for MR and CT.

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans Which notebook are you referring to?

SIRF-Exercises notebook ML_reconstruction compares OSEM with gradient ascent, and so far as I remember, other PET notebooks in SIRF-Exercises do not deal with gradient descent too.

@KrisThielemans
Copy link
Member Author

Synergistic/gradient_descent_mr_pet_ct.ipynb. No need to fix this now though. Next release!

@KrisThielemans KrisThielemans added this to the v3.5 milestone Jan 23, 2023
@KrisThielemans
Copy link
Member Author

b6b0d6b edited the notebook a bit to warn people about the confusion on signs.

@KrisThielemans
Copy link
Member Author

@ckolbPTB should we move this notebook to Introductory in the next release? There isn't anything "synergistic" here really, and it nicely follows up from the other ones in that folder.

@KrisThielemans
Copy link
Member Author

@ckolbPTB what do you think about moving this to Introductory?

@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov would you have time to change the sign here and adjust?

@KrisThielemans
Copy link
Member Author

currently the "ascent" is addressed by updating text in the notebook. This is good enough for 3.5. We'll multiply the PET objective function with -1 and descend in the next version

@KrisThielemans
Copy link
Member Author

Move now completed.

The only thing remaining here is the strange line in the PET reconstructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants