-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Cannot run ./vendor/bin/ecs in 1.8 #525
Labels
Comments
Did not agree creating a 8.x branch in simplify, so the only solution is to upgrade to |
Thank you for the investigation! 🎉 As far as I see, it would also require upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sylius-Standard version: 1.8.9
PHP: 7.3 or 7.4
How to reproduce:
Clone https://github.com/Sylius/Sylius-Standard
Checkout branch 1.8
Run
composer install
Run
./vendor/bin/ecs
Error in console:
[ERROR] in_array() expects parameter 2 to be array, null given
Possible fixes:
symplify/easy-coding-standard:v^9.0
The problem is in
vendor/symplify/easy-coding-standard/src/Yaml/CheckerServiceParametersShifter.php
constructor whereserviceKeywords
comesNULL
instead of empty array.After further investigation found out that in
symfony/dependency-injection:4.4.19
theserviceKeywords
has changed from a property to a constant in this commit.A patch fix can be to change lines 72-73 in
vendor/symplify/easy-coding-standard/src/Yaml/CheckerServiceParametersShifter.php
to:I will try to push a fix to
symplify/easy-coding-standard
repo as well deprecated-packages/symplify#3017.I think same issue might occur in 1.9 as well.
The text was updated successfully, but these errors were encountered: