Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

Add Itunes command #1345

Closed
wants to merge 47 commits into from
Closed

Add Itunes command #1345

wants to merge 47 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2021 •
edited by almeidx
Loading

Added an itunes command

Closes #1322

Edit: I am making this PR draft for now, As I am making the command better. I missed out some test cases and currently working.

@ghost ghost self-requested a review as a code owner October 16, 2021 06:43
@ghost ghost changed the title Add a Itunes command Add Itunes command Oct 16, 2021
Doges
Doges suggested changes Oct 16, 2021
View reviewed changes
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for opening both PRs! I reviewed and found some things that may need to be changed, and again, thanks for contributing for the project.

src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/locales/en-US/commands.json Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
@Doges Doges mentioned this pull request Oct 16, 2021
Closed
@ghost ghost marked this pull request as draft October 17, 2021 10:37
almeidx
almeidx reviewed Oct 17, 2021
View reviewed changes
src/apis/ITunes.js Outdated Show resolved Hide resolved
almeidx
almeidx suggested changes Oct 17, 2021
View reviewed changes
src/apis/ITunes.js Outdated Show resolved Hide resolved
src/apis/ITunes.js Outdated Show resolved Hide resolved
@almeidx
Copy link
Member

almeidx commented Oct 17, 2021 •
edited
Loading

Please revert the changes you made to the env example file. If those are you bots Discord token and database uri, make sure to regenerate them as well.

@ghost
Copy link
Author

ghost commented Oct 17, 2021

Please revert the changes you made to the env example file. If those are you bots Discord token and database uri, make sure to regenerate them as well.

Oops sorry, I did indeed added them too, my mistake.

almeidx
almeidx reviewed Oct 17, 2021
View reviewed changes
.env.example Outdated Show resolved Hide resolved
almeidx
almeidx reviewed Oct 17, 2021
View reviewed changes
src/apis/ITunes.js Outdated Show resolved Hide resolved
Doges
Doges suggested changes Oct 17, 2021
View reviewed changes
src/apis/ITunes.js Outdated Show resolved Hide resolved
@ghost ghost marked this pull request as ready for review October 18, 2021 06:39
@ghost
Copy link
Author

ghost commented Oct 18, 2021 •
edited by ghost
Loading

I have fixed small bugs and made requested changes. The only thing I am not able to do is using parameters instead of spliting. I am having issues while writing. If it is necessary to add, then it would be better to give me an example so that I can reproduce it. I added a comment and received a example but it seems to give me error.

This PR is ready for review.

@ghost ghost requested review from jaxxibae, almeidx and fersilva16 November 3, 2021 01:49
almeidx
almeidx previously approved these changes Nov 4, 2021
View reviewed changes
@almeidx almeidx requested review from a team and removed request for Doges, jaxxibae and fersilva16 November 4, 2021 10:59
moruzerinho6
moruzerinho6 previously approved these changes Nov 5, 2021
View reviewed changes
fersilva16
fersilva16 previously approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@fersilva16 fersilva16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Doges
Doges previously approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Doges
Copy link
Member

Doges commented Nov 13, 2021

Just solve the conflicts before I merge

@ghost
Copy link
Author

ghost commented Nov 13, 2021 •
edited by ghost
Loading

Oh okay :), Done!

@ghost ghost dismissed stale reviews from Doges, fersilva16, moruzerinho6, and almeidx via 0772eec November 13, 2021 12:05
@ghost ghost requested a review from Doges November 13, 2021 12:06
@almeidx almeidx requested review from a team and removed request for Doges November 13, 2021 17:36
almeidx
almeidx suggested changes Nov 13, 2021
View reviewed changes
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
src/commands/misc/itunes.js Outdated Show resolved Hide resolved
@ghost ghost requested review from almeidx and removed request for a team November 14, 2021 04:06
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: commands New command(s) suggestion/addition type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add iTunes commands.
7 participants
@almeidx @Doges @fersilva16 @jaxxibae @moruzerinho6 @puddingpy @easedeath