Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

Translate phrases to emoji command #1313

Closed
wants to merge 22 commits into from
Closed

Translate phrases to emoji command #1313

wants to merge 22 commits into from

Conversation

MoPaMo
Copy link

@MoPaMo MoPaMo commented May 16, 2021

Based on my issue#1312, I have now created a command, which takes user input and translates the words into emojis. Right now, the command has a pretty small range of translations, but I think finding new and fun translation is a great thing for PRs.

I've just tested the algorithm itself and haven't run the entire project myself yet, so I'm not sure whether I "registered" my command...

@MoPaMo MoPaMo requested a review from a team as a code owner May 16, 2021 06:56
almeidx
almeidx suggested changes May 16, 2021
View reviewed changes
src/commands/text/emojitr.js Outdated Show resolved Hide resolved
src/commands/text/emojitr.js Outdated Show resolved Hide resolved
almeidx
almeidx reviewed May 16, 2021
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be better if you used the emojis directly (😅) instead of keeping the :emoji_name: format

@almeidx almeidx added scope: commands New command(s) suggestion/addition type: feature New feature labels May 16, 2021
@almeidx almeidx linked an issue May 16, 2021 that may be closed by this pull request
Translate phrases to emoji command #1312
Open
almeidx
almeidx suggested changes May 16, 2021
View reviewed changes
src/commands/text/emojitr.js Outdated Show resolved Hide resolved
@MoPaMo
Copy link
Author

MoPaMo commented May 16, 2021

I feel like it would be better if you used the emojis directly (😅) instead of keeping the :emoji_name: format

Why? They are converted to emojis by discord and I'm not even sure if the "normal" emojis work…

@almeidx
Copy link
Member

almeidx commented May 16, 2021

I feel like it would be better if you used the emojis directly (sweat_smile) instead of keeping the :emoji_name: format

Why? They are converted to emojis by discord and I'm not even sure if the "normal" emojis work…

It would probably make the code easier to read, but it's not a big deal

@MoPaMo
Copy link
Author

MoPaMo commented May 16, 2021

I don't know 🤷🏼‍♂️ 😂

@almeidx
Copy link
Member

almeidx commented May 16, 2021 •
edited
Loading

Github Actions are sort of dying atm so the checks aren't running, however, whenever they get back up they are going to fail in this pull request because we do not allow semicolons.

For the time being, you can run npm run fix and npm run test locally to see what needs fixing, which is basically what the github actions would have done if they were working

@MoPaMo
Copy link
Author

MoPaMo commented May 17, 2021

I fixed the problems called out by the linter program, so what do I do now?

@MoPaMo MoPaMo requested a review from almeidx May 17, 2021 19:35
@MoPaMo
Copy link
Author

MoPaMo commented May 27, 2021 •
edited
Loading

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

@Doges
Copy link
Member

Doges commented May 28, 2021

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

nothing, i don't have enough time to test it rn, may take more 4 days for my review

@MoPaMo
Copy link
Author

MoPaMo commented May 28, 2021

I‘m kind of frustrated right now - what did I do wrong so I don’t get any answer in two weeks? 🙈

nothing, i don't have enough time to test it rn, may take more 4 days for my review

Sorry for being annoying 😅

almeidx
almeidx suggested changes May 29, 2021
View reviewed changes
src/commands/text/emojitr.js Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@almeidx almeidx almeidx requested changes

Assignees
No one assigned
Labels
scope: commands New command(s) suggestion/addition type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate phrases to emoji command
5 participants
@MoPaMo @almeidx @Doges @pedrofracassi @metehus