Skip to content

Commit 047a71d

Browse files
authored
Merge pull request #606 from Swirrl/no-volumes-in-dockerfile
remove VOLUME from dockerfile -- it's a trap
2 parents fd3e6b6 + a003576 commit 047a71d

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

drafter/README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,15 @@ $ stardog query <database-name> <path-to-migration>
6161
If a version bump requires a migration to be run, it should be noted in the
6262
release notes.
6363

64+
## Docker
65+
66+
CI will build and push a docker image to
67+
68+
```
69+
europe-west2-docker.pkg.dev/swirrl-devops-infrastructure-1/swirrl/drafter-pmd4
70+
```
71+
72+
tagged with git tag, branch name, and commit sha.
73+
74+
Consumers may want to mount volumes at `/app/config` to provide custom
75+
configuration, and at `/app/stasher-cache` to persist the cache.

drafter/build.clj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
:image-type (get opts :image-type :docker)
2929
:include {"/app/config" ["./resources/drafter-auth0.edn"]}
3030
:base-image "gcr.io/distroless/java:11"
31-
:volumes #{"/app/config" "/app/stasher-cache"}
3231
;; NOTE Not as documented!
3332
;; The docstring states that these should be
3433
;; :to-registry {:username ... :password ...}

drafter/deps.edn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
:main-opts ["-m" "mach.pack.alpha.skinny"]}
145145

146146
:build {:deps {io.github.clojure/tools.build {:git/tag "v0.7.5" :git/sha "34727f7"}
147-
io.github.rickmoynihan/pack.alpha {:git/sha "e461cf1ad0e6aa1a9d93e924bcbad32ae52db783"}}
147+
io.github.juxt/pack.alpha {:git/sha "9fd4a63ddeec3bedcbc819422de5a40ccb9eb8c9"}}
148148
:ns-default build}
149149

150150
:java9 {:jvm-opts ["--add-modules" "java.xml.bind"]}

0 commit comments

Comments
 (0)