Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize artifact meta() naming/handling #507

Open
brifordwylie opened this issue Feb 19, 2025 · 0 comments
Open

Standardize artifact meta() naming/handling #507

brifordwylie opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
api Python API Work

Comments

@brifordwylie
Copy link
Member

brifordwylie commented Feb 19, 2025

Right now our meta data get/set/delete methods are a bit all over the place, let's review and standardize naming.

Proposal:

  • Any workbench_meta() should just be meta()
    • meta()
    • upsert_meta()
    • delete_meta()
  • The aws_meta() will stay aws_meta()

Also what do we want to do with refresh_meta()?

    def refresh_meta(self):
        """Refresh our internal AWS Broker catalog metadata"""
        self.data_source_meta = self.meta.data_source(self.uuid, database=self.database)

Also I DataSources don't have a delete_meta()

@brifordwylie brifordwylie added the api Python API Work label Feb 19, 2025
@brifordwylie brifordwylie added this to the Workbench 0.9.0 milestone Feb 19, 2025
@brifordwylie brifordwylie self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Python API Work
Projects
Status: Backlog
Development

No branches or pull requests

1 participant