Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help to understand input logic and lack of [ = ] functionality ... #103

Open
starbock opened this issue Nov 4, 2023 · 2 comments
Open
Assignees
Labels
Bug Something isn't working Priority: Medium Needs to fixed sooner.

Comments

@starbock
Copy link

starbock commented Nov 4, 2023

I am a happy user of your calculator, as it uniquely meets my needs for basic math with parenthesis support and memory functions, which Pebbles is the only calculator that I have found to implement these as expected. I am contacting you because I am puzzled by the input logic when pressing the equals (=) key.

My expectation is that pressing '=' after an expression concludes the calculation and returns the final result. That final result would then become the input for any new expression. However, your calculator seems to continue the initial expression after pressing '=', rather than starting a new calculation with the result.

For example:

Pressing '5 + 1 =' returns 6, as expected
But then pressing 'x 3 =' returns 8, instead of 18
This behavior diverges from other calculators I've used. On my phone, for example, pressing '=' concludes the initial calculation, so '5 + 1 =' followed by 'x 3 =' returns 18.

I imagine Pebbles' current implementation may be intended behavior if the user pressed Enter instead of '=' to conclude the expression; indeed, this would be very convenient to allow incremental input of an expression. But, pressing '=' connotes completion to me. The [ Enter ] and [ = ] functionality are different, and my observation is that there currently is no [ = ] functionality implemented in Pebbles - that's what I'm missing.

Overall your calculator is excellent. I'm just puzzled by this particular input logic. If there is a rationale behind it, I would be very interested to understand. If not, I humbly suggest considering changing the [ = ] behavior to immediately conclude the current calculation, as that would align with more traditional basic calculators.

Thank you for your time and for creating this useful calculator!

@SubhadeepJasu
Copy link
Owner

SubhadeepJasu commented Nov 9, 2023

I have come across this thought too. It's something I didn't think of earlier. May be what can be done, is to automatically put a "Ans" or the result itself when one tries to write something after finding a result. This way the calculator behaves "normally" and keeps chaining results properly.

@SubhadeepJasu SubhadeepJasu added Bug Something isn't working Priority: Medium Needs to fixed sooner. labels Nov 9, 2023
@SubhadeepJasu SubhadeepJasu self-assigned this Nov 9, 2023
@SubhadeepJasu
Copy link
Owner

Also, I have started working on a modern Gtk4 port of the app, which will take some time to come out. This issue should be fixed by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Medium Needs to fixed sooner.
Projects
None yet
Development

No branches or pull requests

2 participants