Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic elements #24

Open
SArpnt opened this issue Jan 7, 2022 · 2 comments
Open

semantic elements #24

SArpnt opened this issue Jan 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@SArpnt
Copy link
Contributor

SArpnt commented Jan 7, 2022

minor complaint but using the details tag would improve accessibility and not need supporting javascript code
already implemented on my website, not entirely sure how styling works for this but i don't think it would be difficult

@SthephanShinkufag SthephanShinkufag added the enhancement New feature or request label Jan 7, 2022
@SArpnt
Copy link
Contributor Author

SArpnt commented Jan 8, 2022

i think this issue should be extended to more elements actually, for example many buttons on the website are divs, which makes them impossible to select with tab (the library buttons seem to have selectable text too), the time counter is a text input and not a number input, and you could probably use some elements like main, aside, article, section, footer, etc.

@SArpnt SArpnt changed the title use details tag instead of button semantic elements Jan 8, 2022
@SArpnt
Copy link
Contributor Author

SArpnt commented May 7, 2022

i think the library should use list elements and the info section use paragraphs instead of line breaks

there should also be an aria-label on the code editor and oscilloscope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants