Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First item won't get active class until scrolled #27

Open
mordechaim opened this issue May 6, 2020 · 0 comments
Open

First item won't get active class until scrolled #27

mordechaim opened this issue May 6, 2020 · 0 comments

Comments

@mordechaim
Copy link

mordechaim commented May 6, 2020 •
edited
Loading

Since the activeNavClass is set in the onScroll it will only capture the class on a tiny scroll.
The expected behaviour would be that the first element is selected on page load.

Thanks for this great library.
@mordechaim mordechaim changed the title First First item won't get active class until scrolled May 6, 2020
mordechaim added a commit to mordechaim/react-scrollspy-nav that referenced this issue May 7, 2020
@mordechaim
Fix StephenWeiXu#27
5bdc506
mordechaim added a commit to mordechaim/react-scrollspy-nav that referenced this issue May 7, 2020
@mordechaim
Merge pull request #1 from mordechaim/fix-27
cb04695 
Fix StephenWeiXu#27
mordechaim pushed a commit to mordechaim/react-scrollspy-nav that referenced this issue May 7, 2020
Fix StephenWeiXu#27
58c649c
@mordechaim mordechaim mentioned this issue May 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mordechaim